Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database): avoid filter bar flickering #8562

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

bytemain
Copy link
Contributor

@bytemain bytemain commented Oct 18, 2024

Recording.at.2024-10-18.16.13.56.mp4

close: #8560

the problem cause is that we render both add filter and {n} more on more view, so the renderCount changes every times when recalculate.

first time we calculate it can place 3 items, after render, we can only place 2 items, and we will re-render...

@bytemain bytemain requested a review from a team as a code owner October 18, 2024 08:17
Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 2:37pm

Copy link

vercel bot commented Oct 18, 2024

@bytemain is attempting to deploy a commit to the toeverything Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: 424716c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Oct 18, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

nx-cloud bot commented Oct 18, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 424716c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@bytemain bytemain changed the title fix(page): avoid filter bar flickering fix(database): avoid filter bar flickering Oct 18, 2024
Copy link

graphite-app bot commented Oct 18, 2024

Merge activity

  • Oct 18, 10:04 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 18, 10:04 AM EDT: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

@zzj3720 zzj3720 merged commit 9c9dc09 into toeverything:master Oct 18, 2024
34 of 35 checks passed
@doouding doouding mentioned this pull request Oct 24, 2024
doouding added a commit that referenced this pull request Oct 24, 2024
## Feat
- feat(blocks): add more html transformer apis (#8573)
- feat(blocks): support more markdown transformer api (#8564)
- feat(blocks): add abort controller to peekviewservice (#8558)
- feat: add docLinkMiddleware for linked doc export (#8553)
## Fix
- fix: mind map dragging issue (#8563)
- fix(database): can't use horizontal scrollbar (#8576)
- fix: note width is less than minimum width after resize and arrange (#8550)
- fix: newly created note alignments cannot be stored persistently (#8551)
- fix: inline range calculation not expected (#8552)
- fix(database): avoid filter bar flickering (#8562)
- fix(database): drag and drop block into database block (#8561)
- fix(blocks): split paragraphs based on newlines (#8556)
- fix(database): incorrect delete row logic (#8544)
- fix: note height less than minimum height (#8542)
## Chore
- chore: add changelog generating script (#8582)
- chore: optimize zip transformer api (#8580)
- chore: adjust attachment click events, like image, to support opening in peek view (#8579)
- chore: remove useless import (#8571)
## Refactor
- refactor: convert built-in component to widget (#8577)
- refactor: migrating legacy tools (#8471)
- refactor: edgeless tool manager (#8438)
- refactor(playground): organize export and import menu items into submenus in the debug menu (#8557)
- refactor: combine unsafeCSS and cssVar (#8545)
## Perf
- perf(edgeless): use css var to place collaboration cursors-n-selections on board zoom change (#8543)
This was referenced Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

the database flickers after adding multiple filter conditions
2 participants